New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the version for core modules ps_legalcompliance ps_linklist ps_customtext ps_customeraccountlinks #8360

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@toutantic
Member

toutantic commented Sep 21, 2017

…t ps_customtext ps_customeraccountlinks

Questions Answers
Branch? 1.7.2.x
Description? set the version in composer.json for some native modules this is needed to be able to release the modules independently of the core
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOGOSS-47
How to test? Please indicate how to best verify that this PR is correct.
CO: fixing the version for core modules ps_legalcompliance ps_linklis…
…t ps_customtext ps_customeraccountlinks
@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Sep 21, 2017

Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Collaborator

prestonBot commented Sep 21, 2017

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@eternoendless eternoendless changed the title from CO: fixing the version for core modules ps_legalcompliance ps_linklis… to Fixing the version for core modules ps_legalcompliance ps_linklist ps_customtext ps_customeraccountlinks Sep 21, 2017

@eternoendless

We should use ^<major_version> in the future

@eternoendless eternoendless added this to the 1.7.2.3 milestone Sep 21, 2017

@eternoendless eternoendless merged commit d432de5 into PrestaShop:1.7.2.x Sep 21, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 21, 2017

Thank you @toutantic

@prestonBot prestonBot referenced this pull request Sep 23, 2017

Closed

1.7.2.x #8363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment