New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in Access::getRoles() #8362

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
5 participants
@Yolandavdvegt
Contributor

Yolandavdvegt commented Sep 22, 2017

Updated getRoles() so it only returns the roles for the specified profile. Before the fix it would return all the existing authorization_roles in the db, no matter what profile is specified.

Questions Answers
Branch? develop
Description? Updated getRoles() so it only returns the roles for the specified profile. Before the fix it would return all the existing authorization_roles in the db, no matter what profile is specified.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Run Access::getRoles(profile_id) from a test controller. Use a profile_id from a new created profile with no auth rules set, you should get 0 results.. Add one auth role to the profile, now getRoles() should return 1 result.

This change is Reviewable

CO: Fixed bug in Access::getRoles()
Updated getRoles() so it only returns the roles for the specified profile. Before the fix it would return all the existing authorization_roles in the db, no matter what profile is specified.
@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Sep 22, 2017

Collaborator

Hello Yolandavdvegt!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Sep 22, 2017

Hello Yolandavdvegt!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 6, 2017

@eternoendless eternoendless changed the title from CO: Fixed bug in Access::getRoles() to Fixed bug in Access::getRoles() Oct 24, 2017

@eternoendless eternoendless added this to the 1.7.3.0 milestone Oct 24, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Oct 24, 2017

Thank you @Yolandavdvegt

@eternoendless eternoendless merged commit 0927d82 into PrestaShop:develop Oct 24, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment