New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Administration Page to Symfony #8365

Merged
merged 32 commits into from Nov 28, 2017

Conversation

Projects
None yet
7 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Sep 25, 2017

Questions Answers
Branch? develop
Description? Self described
Type? improvement
Category? BO
BC breaks? yes (controller override)
Deprecations? probably
Fixed ticket? BOGOSS-49
How to test? Access Configure > Advanced Parameters > Administration

Todo:

  • Deletions
    • Remove AdminPreferencesController
    • Remove related old templates
  • Creations
    • PrestaShopBundle/Controller/AdvancedParameters/AdministrationController
    • Add routing
    • Complete Link class to map PrestaShop menu to the new page
    • Create General, UploadQuota and Notifications Symfony forms
    • Added help/info tips labels and messages
    • Create the Twig template using PrestaShop UI Kit (UI kit is not ready)
    • Forms submission
    • Forms validation
    • Parameters update
    • Error Handling and permissions
    • Re-introduced hooks

This change is Reviewable

@PrestaShop PrestaShop deleted a comment from prestonBot Sep 25, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 29, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 29, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 29, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 3, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 3, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 3, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 3, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 3, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 3, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 13, 2017

Member

@mickaelandrieu, it seems this PR also includes #8279. This makes it quite big to be reviewed. :)

Member

Quetzacoalt91 commented Oct 13, 2017

@mickaelandrieu, it seems this PR also includes #8279. This makes it quite big to be reviewed. :)

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 13, 2017

Member

Accessing the page works properly, thanks. However, submitting new options doesn't work, as the old values keep appeared once the page refreshed.

Member

Quetzacoalt91 commented Oct 13, 2017

Accessing the page works properly, thanks. However, submitting new options doesn't work, as the old values keep appeared once the page refreshed.

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 13, 2017

Member

Another request regarding these pages on Firefox, can you please add the class custom-select in order to improve the style?

We would get the same result as the first select:
capture du 2017-10-13 16-49-59

Member

Quetzacoalt91 commented Oct 13, 2017

Another request regarding these pages on Firefox, can you please add the class custom-select in order to improve the style?

We would get the same result as the first select:
capture du 2017-10-13 16-49-59

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 24, 2017

Contributor

Comments have been adressed, PR rebased and Coding styles issues fixed => Ready for review :)

Contributor

mickaelandrieu commented Oct 24, 2017

Comments have been adressed, PR rebased and Coding styles issues fixed => Ready for review :)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu
Contributor

mickaelandrieu commented Nov 23, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 23, 2017

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Nov 24, 2017

Contributor

@mickaelandrieu

In 1.7.2.4 there was tooltips in Administration page

tooltip administration 1724

I don't see them anymore

missing tooltip administration 1730

Contributor

marionf commented Nov 24, 2017

@mickaelandrieu

In 1.7.2.4 there was tooltips in Administration page

tooltip administration 1724

I don't see them anymore

missing tooltip administration 1730

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 27, 2017

Contributor

@marionf sounds better now 👍

admin

Contributor

mickaelandrieu commented Nov 27, 2017

@marionf sounds better now 👍

admin

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 27, 2017

Member

@mickaelandrieu you sent a screenshot of the new form (with units), but you did not commit them. :(

Member

Quetzacoalt91 commented Nov 27, 2017

@mickaelandrieu you sent a screenshot of the new form (with units), but you did not commit them. :(

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 28, 2017

Contributor

@Quetzacoalt91 it happens I spend all my days switching from branches and from Symfony 2 to Symfony 3. Let's release 1.7.3 asap, I have some sort of fatigue of this transitional period :/

done

Contributor

mickaelandrieu commented Nov 28, 2017

@Quetzacoalt91 it happens I spend all my days switching from branches and from Symfony 2 to Symfony 3. Let's release 1.7.3 asap, I have some sort of fatigue of this transitional period :/

done

BO: re-introduced missing specific unity fields
* 'migration/administration-page' of https://github.com/mickaelandrieu/PrestaShop:
  BO: added all help messages
  BO: use ::class sugar in forms
  BO: fixed translation keys
  BO: added custom classes
  TE: remove useless test
  BO: improved form category logos
  BO: changed url to new Controller + delete old one
  BO: mapped Notifications form
  BO: mapped UploadQuota form
  BO: mapped GeneralForm
  BO: form submit ok
  BO: form rendering OK
  BO: introduced form provider/handler
  BO: complete Sf forms
  BO: started Administration page migration
  BO: fixed Codacy warning
  BO: fixed display of memcache servers

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 28, 2017

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 28, 2017

Contributor

Note that some translations keys have been changed of domain, because this comes from "hint" message of old forms and shouldn't be located into Admin.Advparameters.Feature domain. It's a bug, this is why I couldn't stay iso-functional this time 👍

Contributor

mickaelandrieu commented Nov 28, 2017

Note that some translations keys have been changed of domain, because this comes from "hint" message of old forms and shouldn't be located into Admin.Advparameters.Feature domain. It's a bug, this is why I couldn't stay iso-functional this time 👍

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 28, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit cfb58b2 into PrestaShop:develop Nov 28, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 28, 2017

Thank you @mickaelandrieu

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:migration/administration-page branch Nov 28, 2017

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 28, 2017

Contributor

\o/

Contributor

mickaelandrieu commented Nov 28, 2017

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment