New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default country instead of translator locale for marketplace API #8366

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
6 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 26, 2017

Questions Answers
Branch? 1.7.2.x
Description? This PR is a partial revert of #7778, where the wrong ISO code was sent to the Marketplace API.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3842
How to test? Change your default country in International > Localization, empty the cache and look for changes in the module list. Stripe can be used as a reference.
@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Sep 26, 2017

Contributor

Yeeeep, so this is why my migrate from 1.6 to 1.7 went wrong, rotfl, thank you for that fix @Quetzacoalt91

Contributor

kpodemski commented Sep 26, 2017

Yeeeep, so this is why my migrate from 1.6 to 1.7 went wrong, rotfl, thank you for that fix @Quetzacoalt91

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 26, 2017

Member

Seriously?!? I wasn't aware of this side-effect 😮

Member

Quetzacoalt91 commented Sep 26, 2017

Seriously?!? I wasn't aware of this side-effect 😮

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.2.3 milestone Sep 26, 2017

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Sep 26, 2017

Contributor

Yeah method checking native modules and disable non native ones was broken because of that, overall autoupgrade in beta version works really good and i'm dissapointed to see that 1.6.8 completely get rid off it :/

Contributor

kpodemski commented Sep 26, 2017

Yeah method checking native modules and disable non native ones was broken because of that, overall autoupgrade in beta version works really good and i'm dissapointed to see that 1.6.8 completely get rid off it :/

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Sep 26, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/Core/Addon/Module/ModuleManagerBuilder.php  1
         

See the complete overview on Codacy

codacy-bot commented Sep 26, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/Core/Addon/Module/ModuleManagerBuilder.php  1
         

See the complete overview on Codacy

@eternoendless

Code looks good!

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Sep 27, 2017

Contributor

Tested and ok, thanks !

Contributor

vincentbz commented Sep 27, 2017

Tested and ok, thanks !

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 28, 2017

Thank you @Quetzacoalt91

@eternoendless eternoendless merged commit 819a227 into PrestaShop:1.7.2.x Sep 28, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment