New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor visual issue in Information page #8377

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
2 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Sep 28, 2017

Questions Answers
Branch? develop
Description? Fixed margin on notification message
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Nothing to do, just merge please :)

Important guidelines

else
$('#changedFiles').html('<div class="alert alert-success">'+ translations.noChangeDetected +'</div>');
$('#changedFiles').html('<div class="alert alert-success"><ul><li>'+ translations.noChangeDetected +'</li></ul></div>');

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Sep 28, 2017

Member

You just display a string, why don't you use <p></p> instead?

This is what you did in the compromised page 😉

@Quetzacoalt91

Quetzacoalt91 Sep 28, 2017

Member

You just display a string, why don't you use <p></p> instead?

This is what you did in the compromised page 😉

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 2, 2017

Contributor

This is how you should render a notification block, according to UI kit. The "compromised" page have not been designed 👍

@mickaelandrieu

mickaelandrieu Oct 2, 2017

Contributor

This is how you should render a notification block, according to UI kit. The "compromised" page have not been designed 👍

@Quetzacoalt91 Quetzacoalt91 merged commit 890efa1 into PrestaShop:develop Oct 2, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment