New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests have now their own database, and the database is properly regenerated at the initial state before each test #8379

Merged
merged 21 commits into from Oct 12, 2017

Conversation

Projects
None yet
7 participants
@jocel1
Contributor

jocel1 commented Sep 28, 2017

Questions Answers
Branch? develop
Description? Improve unit tests
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? composer test \o/

This change is Reviewable

@jocel1 jocel1 added the WIP label Sep 28, 2017

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Sep 28, 2017

Contributor

WIP, now tests need to be fixed!

Contributor

jocel1 commented Sep 28, 2017

WIP, now tests need to be fixed!

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 28, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 29, 2017

Member

Hello @jocel1,

You should work on the branch develop, as the 1.7.2.3 should be the last version released of the 1.7.2.x will go live in the next few weeks (days?).

Member

Quetzacoalt91 commented Sep 29, 2017

Hello @jocel1,

You should work on the branch develop, as the 1.7.2.3 should be the last version released of the 1.7.2.x will go live in the next few weeks (days?).

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Sep 29, 2017

Contributor

no problem, I'll rebase it on develop!

Contributor

jocel1 commented Sep 29, 2017

no problem, I'll rebase it on develop!

@jocel1 jocel1 changed the base branch from 1.7.2.x to develop Sep 29, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 29, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 29, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 29, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 30, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 30, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 30, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 30, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 30, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 1, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 1, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 1, 2017

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Oct 2, 2017

Contributor

As far as I can tell, there was only one added strings, for which I made a suggestion. What do you think, @AlexEven ?

Contributor

xBorderie commented Oct 2, 2017

As far as I can tell, there was only one added strings, for which I made a suggestion. What do you think, @AlexEven ?

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 2, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 2, 2017

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 2, 2017

Contributor

I like it, I need to find time to review this one 👍 Good job @jocel1 !

Contributor

mickaelandrieu commented Oct 2, 2017

I like it, I need to find time to review this one 👍 Good job @jocel1 !

@jocel1 jocel1 removed the WIP label Oct 4, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 4, 2017

@eternoendless eternoendless changed the title from TE: Tests have now their own database, and the database is properly r… to Tests have now their own database, and the database is properly r… Oct 4, 2017

@mickaelandrieu

Good job! Some minor requests

Show outdated Hide outdated classes/DateRange.php
Show outdated Hide outdated install-dev/init.php
Show outdated Hide outdated src/PrestaShopBundle/Install/Install.php

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 4, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Oct 4, 2017

Member

Reviewed 13 of 18 files at r1, 2 of 6 files at r2, 22 of 24 files at r3, 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 15 unresolved discussions, some commit checks failed.


classes/DateRange.php, line 60 at r4 (raw file):

		SELECT `id_date_range`, `time_end`
		FROM `'._DB_PREFIX_.'date_range`
		WHERE `time_end` ORDER BY time_end DESC');

Maybe add LIMIT 1?


classes/Tools.php, line 53 at r4 (raw file):

    }

    public static function resetRequest()

Please add a PhpDoc header on your new methods.

It is important that each method describes:

  • A short summary of what it does
  • Type (and if possible, a description) of each parameter
  • Type and description of what it returns
  • Exceptions thrown and when

If your method is an extension of a parent class' method, you can use @inheritdoc.

Documenting methods is important because

  • It enables autocompletion by IDEs
  • It eases code understanding

Example:

   /**
     * Executes the current command.
     *
     * This method is not abstract because you can use this class
     * as a concrete class. In this case, instead of defining the
     * execute() method, you set the code to execute by passing
     * a Closure to the setCode() method.
     *
     * @param InputInterface  $input  An InputInterface instance
     * @param OutputInterface $output An OutputInterface instance
     *
     * @return null|int null or 0 if everything went fine, or an error code
     *
     * @throws LogicException When this abstract method is not implemented
     *
     * @see setCode()
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        // ...
    }

You can find out more about PhpDoc by reading the proposed PSR-5 standard.


classes/Tools.php, line 2139 at r4 (raw file):

    {
        if (defined('_PS_IN_TEST_')
            || (defined('PS_INSTALLATION_IN_PROGRESS') && $rewrite_settings === null)) {

When using multiline ifs, please put the closing parenthesis in a new line, like this:

if ($foo
    && $bar
) {
    // do something
}

src/PrestaShopBundle/Install/DatabaseDump.php, line 122 at r4 (raw file):

    {
        $dumpCommand = $this->buildMySQLCommand('mysqldump', array($this->databaseName));
        $dumpCommand .= ' > ' . escapeshellarg($this->dumpFile). ' 2> /dev/null';

Why are you suppressing stderr?


src/PrestaShopBundle/Install/Install.php, line 305 at r4 (raw file):

    public function generateSf2ProductionEnv()
    {
        $schemaUpgrade = new UpgradeDatabase(defined('_PS_IN_TEST_')?'test':null);

Please add a space around the ? and : operators


src/PrestaShopBundle/Install/Install.php, line 360 at r4 (raw file):



    public function initializeTestContext()

Missing Phpdoc


src/PrestaShopBundle/Install/Install.php, line 407 at r4 (raw file):

    }

    public static function createTestDB() {

Missing Phpdoc


src/PrestaShopBundle/Install/Install.php, line 407 at r4 (raw file):

    }

    public static function createTestDB() {

I don't think this method belongs here. To me, this looks like a fixture that consumes Install, not a part of it.


src/PrestaShopBundle/Install/Install.php, line 441 at r4 (raw file):

    }

    public static function restoreTestDB()

Missing Phpdoc


src/PrestaShopBundle/Install/Install.php, line 441 at r4 (raw file):

    }

    public static function restoreTestDB()

Same comment as restoreTestDB()


src/PrestaShopBundle/Install/Install.php, line 480 at r4 (raw file):

                    }
                }
                $iso_codes_to_install = array_flip(array_flip($iso_codes_to_install));

🤔 this is odd...
Should use array_unique instead maybe?


src/PrestaShopBundle/Tests/Model/Product/AdminModelAdapterTest.php, line 172 at r4 (raw file):

        \Context::getContext()->shop = new \Shop(1);
        \Context::getContext()->language = new \Language(1);
        \Context::getContext()->currency = new \Currency(1);

Why not use ContextMocker?
You may need to rebase on develop


tests/bootstrap-admin.php, line 28 at r4 (raw file):

define('_PS_ROOT_DIR_', __DIR__ . '/..');
define('_PS_IN_TEST_', true);
umask(0000); // This will let the permissions be 0775

Shouldn't this be 002 for that?


tests/Integration/Core/Module/HookRepositoryTest.php, line 54 at r4 (raw file):

        $modules = [
            'ps_emailsubscription',
            'ps_featuredproducts'

Why did you change the module here?


tests/Unit/Core/Business/Payment/PaymentOptionFormDecoratorTest.php, line 53 at r4 (raw file):

<form>
    <input type='text' name='card_number'>
<button style='display:none' id='pay-with-OPTION_ID' type='submit'></button>

Looks like you removed an indentation here


Comments from Reviewable

Member

eternoendless commented Oct 4, 2017

Reviewed 13 of 18 files at r1, 2 of 6 files at r2, 22 of 24 files at r3, 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 15 unresolved discussions, some commit checks failed.


classes/DateRange.php, line 60 at r4 (raw file):

		SELECT `id_date_range`, `time_end`
		FROM `'._DB_PREFIX_.'date_range`
		WHERE `time_end` ORDER BY time_end DESC');

Maybe add LIMIT 1?


classes/Tools.php, line 53 at r4 (raw file):

    }

    public static function resetRequest()

Please add a PhpDoc header on your new methods.

It is important that each method describes:

  • A short summary of what it does
  • Type (and if possible, a description) of each parameter
  • Type and description of what it returns
  • Exceptions thrown and when

If your method is an extension of a parent class' method, you can use @inheritdoc.

Documenting methods is important because

  • It enables autocompletion by IDEs
  • It eases code understanding

Example:

   /**
     * Executes the current command.
     *
     * This method is not abstract because you can use this class
     * as a concrete class. In this case, instead of defining the
     * execute() method, you set the code to execute by passing
     * a Closure to the setCode() method.
     *
     * @param InputInterface  $input  An InputInterface instance
     * @param OutputInterface $output An OutputInterface instance
     *
     * @return null|int null or 0 if everything went fine, or an error code
     *
     * @throws LogicException When this abstract method is not implemented
     *
     * @see setCode()
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        // ...
    }

You can find out more about PhpDoc by reading the proposed PSR-5 standard.


classes/Tools.php, line 2139 at r4 (raw file):

    {
        if (defined('_PS_IN_TEST_')
            || (defined('PS_INSTALLATION_IN_PROGRESS') && $rewrite_settings === null)) {

When using multiline ifs, please put the closing parenthesis in a new line, like this:

if ($foo
    && $bar
) {
    // do something
}

src/PrestaShopBundle/Install/DatabaseDump.php, line 122 at r4 (raw file):

    {
        $dumpCommand = $this->buildMySQLCommand('mysqldump', array($this->databaseName));
        $dumpCommand .= ' > ' . escapeshellarg($this->dumpFile). ' 2> /dev/null';

Why are you suppressing stderr?


src/PrestaShopBundle/Install/Install.php, line 305 at r4 (raw file):

    public function generateSf2ProductionEnv()
    {
        $schemaUpgrade = new UpgradeDatabase(defined('_PS_IN_TEST_')?'test':null);

Please add a space around the ? and : operators


src/PrestaShopBundle/Install/Install.php, line 360 at r4 (raw file):



    public function initializeTestContext()

Missing Phpdoc


src/PrestaShopBundle/Install/Install.php, line 407 at r4 (raw file):

    }

    public static function createTestDB() {

Missing Phpdoc


src/PrestaShopBundle/Install/Install.php, line 407 at r4 (raw file):

    }

    public static function createTestDB() {

I don't think this method belongs here. To me, this looks like a fixture that consumes Install, not a part of it.


src/PrestaShopBundle/Install/Install.php, line 441 at r4 (raw file):

    }

    public static function restoreTestDB()

Missing Phpdoc


src/PrestaShopBundle/Install/Install.php, line 441 at r4 (raw file):

    }

    public static function restoreTestDB()

Same comment as restoreTestDB()


src/PrestaShopBundle/Install/Install.php, line 480 at r4 (raw file):

                    }
                }
                $iso_codes_to_install = array_flip(array_flip($iso_codes_to_install));

🤔 this is odd...
Should use array_unique instead maybe?


src/PrestaShopBundle/Tests/Model/Product/AdminModelAdapterTest.php, line 172 at r4 (raw file):

        \Context::getContext()->shop = new \Shop(1);
        \Context::getContext()->language = new \Language(1);
        \Context::getContext()->currency = new \Currency(1);

Why not use ContextMocker?
You may need to rebase on develop


tests/bootstrap-admin.php, line 28 at r4 (raw file):

define('_PS_ROOT_DIR_', __DIR__ . '/..');
define('_PS_IN_TEST_', true);
umask(0000); // This will let the permissions be 0775

Shouldn't this be 002 for that?


tests/Integration/Core/Module/HookRepositoryTest.php, line 54 at r4 (raw file):

        $modules = [
            'ps_emailsubscription',
            'ps_featuredproducts'

Why did you change the module here?


tests/Unit/Core/Business/Payment/PaymentOptionFormDecoratorTest.php, line 53 at r4 (raw file):

<form>
    <input type='text' name='card_number'>
<button style='display:none' id='pay-with-OPTION_ID' type='submit'></button>

Looks like you removed an indentation here


Comments from Reviewable

@eternoendless

See my comments on reviewable :)

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Oct 4, 2017

Contributor

Review status: 34 of 38 files reviewed at latest revision, 18 unresolved discussions, some commit checks failed.


src/PrestaShopBundle/Install/DatabaseDump.php, line 122 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Why are you suppressing stderr?

Because the command is generating a warning in Travis about password used in command line, and some tests are failing because of this warning


src/PrestaShopBundle/Install/Install.php, line 407 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

I don't think this method belongs here. To me, this looks like a fixture that consumes Install, not a part of it.

I agree, moved into PrestaShopBundle\Tests\Utils\Database


src/PrestaShopBundle/Install/Install.php, line 480 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

🤔 this is odd...
Should use array_unique instead maybe?

Changed :) It seems the reason for this code is: https://stackoverflow.com/questions/8321620/array-unique-vs-array-flip


src/PrestaShopBundle/Tests/Model/Product/AdminModelAdapterTest.php, line 172 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Why not use ContextMocker?
You may need to rebase on develop

at this point of the code, since the objects are available, it was easier to use real objects instead of mocks


tests/Integration/Core/Module/HookRepositoryTest.php, line 54 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Why did you change the module here?

because ps_shoppingcart is not part of the modules we install during the test installation. List of available modules is quite short actually: https://github.com/PrestaShop/PrestaShop/tree/develop/tests/resources/modules


tests/Unit/Core/Business/Payment/PaymentOptionFormDecoratorTest.php, line 53 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Looks like you removed an indentation here

It's expected, the test was failing with the extra indentation


classes/DateRange.php, line 60 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Maybe add LIMIT 1?

I reverted the change, not related to this PR


Comments from Reviewable

Contributor

jocel1 commented Oct 4, 2017

Review status: 34 of 38 files reviewed at latest revision, 18 unresolved discussions, some commit checks failed.


src/PrestaShopBundle/Install/DatabaseDump.php, line 122 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Why are you suppressing stderr?

Because the command is generating a warning in Travis about password used in command line, and some tests are failing because of this warning


src/PrestaShopBundle/Install/Install.php, line 407 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

I don't think this method belongs here. To me, this looks like a fixture that consumes Install, not a part of it.

I agree, moved into PrestaShopBundle\Tests\Utils\Database


src/PrestaShopBundle/Install/Install.php, line 480 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

🤔 this is odd...
Should use array_unique instead maybe?

Changed :) It seems the reason for this code is: https://stackoverflow.com/questions/8321620/array-unique-vs-array-flip


src/PrestaShopBundle/Tests/Model/Product/AdminModelAdapterTest.php, line 172 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Why not use ContextMocker?
You may need to rebase on develop

at this point of the code, since the objects are available, it was easier to use real objects instead of mocks


tests/Integration/Core/Module/HookRepositoryTest.php, line 54 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Why did you change the module here?

because ps_shoppingcart is not part of the modules we install during the test installation. List of available modules is quite short actually: https://github.com/PrestaShop/PrestaShop/tree/develop/tests/resources/modules


tests/Unit/Core/Business/Payment/PaymentOptionFormDecoratorTest.php, line 53 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Looks like you removed an indentation here

It's expected, the test was failing with the extra indentation


classes/DateRange.php, line 60 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Maybe add LIMIT 1?

I reverted the change, not related to this PR


Comments from Reviewable

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Oct 4, 2017

Contributor

Reviewed 1 of 24 files at r3.
Review status: 28 of 41 files reviewed at latest revision, 18 unresolved discussions.


Comments from Reviewable

Contributor

jocel1 commented Oct 4, 2017

Reviewed 1 of 24 files at r3.
Review status: 28 of 41 files reviewed at latest revision, 18 unresolved discussions.


Comments from Reviewable

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Oct 4, 2017

Contributor

Reviewed 9 of 18 files at r1, 1 of 6 files at r2, 19 of 24 files at r3, 3 of 5 files at r5, 11 of 11 files at r6.
Review status: all files reviewed at latest revision, 18 unresolved discussions.


Comments from Reviewable

Contributor

jocel1 commented Oct 4, 2017

Reviewed 9 of 18 files at r1, 1 of 6 files at r2, 19 of 24 files at r3, 3 of 5 files at r5, 11 of 11 files at r6.
Review status: all files reviewed at latest revision, 18 unresolved discussions.


Comments from Reviewable

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Oct 4, 2017

Contributor

Review status: all files reviewed at latest revision, 17 unresolved discussions.


tests/bootstrap-admin.php, line 28 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Shouldn't this be 002 for that?

Comment changed


Comments from Reviewable

Contributor

jocel1 commented Oct 4, 2017

Review status: all files reviewed at latest revision, 17 unresolved discussions.


tests/bootstrap-admin.php, line 28 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

Shouldn't this be 002 for that?

Comment changed


Comments from Reviewable

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 4, 2017

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Oct 9, 2017

Contributor

changes done!

Contributor

jocel1 commented Oct 9, 2017

changes done!

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Oct 9, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 5
           

Complexity increasing per file
==============================
- classes/Tools.php  1
- tests/Unit/classes/ToolsCoreTest.php  2
- src/PrestaShopBundle/Tests/Controller/ControllerTest.php  1
- tests/TestCase/UnitTestCase.php  2
- src/PrestaShopBundle/Command/UpdateSchemaCommand.php  1
- tests/Integration/PrestaShopBundle/Test/WebTestCase.php  1
- tests/Unit/controller/admin/AdminTabsControllerTest.php  1
- tests/Integration/classes/module/ModuleGetPossibleHooksListTest.php  1
- src/PrestaShopBundle/Install/Install.php  16
         

Complexity decreasing per file
==============================
+ tests/Integration/classes/CartGetOrderTotalTest.php  -1
+ install-dev/controllers/http/process.php  -3
         

See the complete overview on Codacy

codacy-bot commented Oct 9, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 5
           

Complexity increasing per file
==============================
- classes/Tools.php  1
- tests/Unit/classes/ToolsCoreTest.php  2
- src/PrestaShopBundle/Tests/Controller/ControllerTest.php  1
- tests/TestCase/UnitTestCase.php  2
- src/PrestaShopBundle/Command/UpdateSchemaCommand.php  1
- tests/Integration/PrestaShopBundle/Test/WebTestCase.php  1
- tests/Unit/controller/admin/AdminTabsControllerTest.php  1
- tests/Integration/classes/module/ModuleGetPossibleHooksListTest.php  1
- src/PrestaShopBundle/Install/Install.php  16
         

Complexity decreasing per file
==============================
+ tests/Integration/classes/CartGetOrderTotalTest.php  -1
+ install-dev/controllers/http/process.php  -3
         

See the complete overview on Codacy

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 9, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Oct 11, 2017

Member

:lgtm:


Reviewed 1 of 1 files at r7.
Review status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.


tests/Unit/Core/Business/Payment/PaymentOptionFormDecoratorTest.php, line 53 at r4 (raw file):

Previously, jocel1 (Jocelyn Fournier) wrote…

It's expected, the test was failing with the extra indentation

What? How come? If a test fails because of code indentation, there's something wrong somewhere 😐


Comments from Reviewable

Member

eternoendless commented Oct 11, 2017

:lgtm:


Reviewed 1 of 1 files at r7.
Review status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.


tests/Unit/Core/Business/Payment/PaymentOptionFormDecoratorTest.php, line 53 at r4 (raw file):

Previously, jocel1 (Jocelyn Fournier) wrote…

It's expected, the test was failing with the extra indentation

What? How come? If a test fails because of code indentation, there's something wrong somewhere 😐


Comments from Reviewable

@eternoendless eternoendless changed the title from Tests have now their own database, and the database is properly r… to Tests have now their own database, and the database is properly regenerated at the initial state before each test Oct 12, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Oct 12, 2017

Member

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


tests/Unit/Core/Business/Payment/PaymentOptionFormDecoratorTest.php, line 53 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

What? How come? If a test fails because of code indentation, there's something wrong somewhere 😐

We'll fix that later


Comments from Reviewable

Member

eternoendless commented Oct 12, 2017

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


tests/Unit/Core/Business/Payment/PaymentOptionFormDecoratorTest.php, line 53 at r4 (raw file):

Previously, eternoendless (Pablo Borowicz) wrote…

What? How come? If a test fails because of code indentation, there's something wrong somewhere 😐

We'll fix that later


Comments from Reviewable

@eternoendless eternoendless merged commit 94c8f1a into PrestaShop:develop Oct 12, 2017

2 of 3 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
code-review/reviewable 41 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Oct 12, 2017

Thank you @jocel1

@xBorderie xBorderie added this to the 1.7.3.0 milestone Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment