New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild all assets with UI kit beta #8386

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
3 participants
@eternoendless
Member

eternoendless commented Oct 3, 2017

Questions Answers
Branch? develop
Description? When I merged 1.7.2.x into develop after the release of 1.7.2.2 at the end of August, the merge brought admin-dev/themes/new-theme/package-lock.json (which didn't exist before). That package-lock had the alpha version of the UI Kit instead of the beta one.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Cross your fingers

@eternoendless eternoendless requested a review from Quetzacoalt91 Oct 3, 2017

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Oct 3, 2017

Contributor

I'd really rather cross my legs ;)

Contributor

xBorderie commented Oct 3, 2017

I'd really rather cross my legs ;)

@Quetzacoalt91

Seems it worked. :)

@Quetzacoalt91 Quetzacoalt91 merged commit d655b58 into PrestaShop:develop Oct 4, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Oct 4, 2017

Contributor

tumblr_npfdtdfr4j1tbr3a1o2_r1_500

Contributor

xBorderie commented Oct 4, 2017

tumblr_npfdtdfr4j1tbr3a1o2_r1_500

@eternoendless eternoendless deleted the eternoendless:fix-package branch Oct 4, 2017

@xBorderie xBorderie added this to the 1.7.3.0 milestone Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment