New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL fixtures and improvements in BO #8388

Merged
merged 5 commits into from Oct 4, 2017

Conversation

Projects
None yet
5 participants
@Danoosh
Contributor

Danoosh commented Oct 4, 2017

Questions Answers
Branch? rtl
Description? Some RTL improvements and fix some rtl bugs.
Add rtfix files to improve BO style sheets, fix Tinymce editor view and text direction, Add class to body tag for lang iso and rtl
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Add an RTL language to Prestashop and see the Prestashop BO after generating rtl style sheets.

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 4, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 4, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 4, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Oct 4, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- js/admin/tinymce.inc.js  2
         

See the complete overview on Codacy

codacy-bot commented Oct 4, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- js/admin/tinymce.inc.js  2
         

See the complete overview on Codacy

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 4, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Oct 4, 2017

Thank you @Danoosh

@eternoendless eternoendless merged commit 4d3d4b8 into PrestaShop:rtl Oct 4, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xBorderie xBorderie added this to the 1.7.3.0 milestone Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment