New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icelandic as supported language #8390

Merged
merged 2 commits into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@AlexEven
Contributor

AlexEven commented Oct 4, 2017

Questions Answers
Branch? develop.
Description? Adding Icelandic as a supported language to retrieve Crowdin translation.
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a.
How to test? Icelandic should be available in Translation > Add/Update a language drop-down, and after adding it, you should get the translation as available in Crowdin (=not much for now).

@AlexEven AlexEven added this to the 1.7.3.0 milestone Oct 4, 2017

@eternoendless

I don't see a localization pack for is (localization/is.xml). Did you perchance forget it?

@eternoendless eternoendless changed the title from BO: Add Icelandic as supported language to Add Icelandic as supported language Oct 4, 2017

@AlexEven AlexEven added the WIP label Oct 4, 2017

@AlexEven

This comment has been minimized.

Show comment
Hide comment
@AlexEven

AlexEven Oct 4, 2017

Contributor

I didn't forget it, it's two different things. Localization pack helps you set up a country with its language and taxes and other localization data.
Here it's simply adding the language so you can get the translations.
Localization will come later (if I have both the time and info needed).

I'm doing another commit since the Translations page does not work as is, a little modification is needed.

Thanks!

Contributor

AlexEven commented Oct 4, 2017

I didn't forget it, it's two different things. Localization pack helps you set up a country with its language and taxes and other localization data.
Here it's simply adding the language so you can get the translations.
Localization will come later (if I have both the time and info needed).

I'm doing another commit since the Translations page does not work as is, a little modification is needed.

Thanks!

@AlexEven

This comment has been minimized.

Show comment
Hide comment
@AlexEven

AlexEven Oct 4, 2017

Contributor

Note: I had to add Icelandic to app/Resources/legacy-to-standard-locales.json otherwise the translation page would display an error.

Contributor

AlexEven commented Oct 4, 2017

Note: I had to add Icelandic to app/Resources/legacy-to-standard-locales.json otherwise the translation page would display an error.

@AlexEven AlexEven removed the WIP label Oct 4, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 7f67ab0 into PrestaShop:develop Oct 6, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 6, 2017

Thank you @AlexEven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment