New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing translations of Information System page #8391

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Oct 4, 2017

Questions Answers
Branch? develop
Description? "Ok" and "Database information" keys were not found.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Forge? http://forge.prestashop.com/browse/BOOM-3940
How to test? In "dev" mode, visit the System Information page: you shouldn't see any warning in translations section of the Symfony debug toolbar.

This change is Reviewable

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 9, 2017

Member

L. 231 of the same file, it seems we can add a missing domain. :)

Member

Quetzacoalt91 commented Oct 9, 2017

L. 231 of the same file, it seems we can add a missing domain. :)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 10, 2017

Contributor

L. 231 of the same file, it seems we can add a missing domain. :)

nope, it uses the defined default domain, see L.26 :)

Contributor

mickaelandrieu commented Oct 10, 2017

L. 231 of the same file, it seems we can add a missing domain. :)

nope, it uses the defined default domain, see L.26 :)

@marionf marionf added the QA ✔️ label Oct 16, 2017

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 16, 2017

Contributor

@Quetzacoalt91 please review and merge 👍

Contributor

mickaelandrieu commented Oct 16, 2017

@Quetzacoalt91 please review and merge 👍

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 16, 2017

Member

Dude did you forget to push?

Member

Quetzacoalt91 commented Oct 16, 2017

Dude did you forget to push?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 20, 2017

Member

I wanted to go faster and push the changes for you, but ...

Décompte des objets: 9, fait.
Delta compression using up to 4 threads.
Compression des objets: 100% (8/8), fait.
Écriture des objets: 100% (9/9), 751 bytes | 0 bytes/s, fait.
Total 9 (delta 5), reused 0 (delta 0)
remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
To https://github.com/mickaelandrieu/PrestaShop.git
 ! [remote rejected]       fix/missing-trads -> fix/missing-trads (permission denied)
error: impossible de pousser des références vers 'https://github.com/mickaelandrieu/PrestaShop.git'

Member

Quetzacoalt91 commented Oct 20, 2017

I wanted to go faster and push the changes for you, but ...

Décompte des objets: 9, fait.
Delta compression using up to 4 threads.
Compression des objets: 100% (8/8), fait.
Écriture des objets: 100% (9/9), 751 bytes | 0 bytes/s, fait.
Total 9 (delta 5), reused 0 (delta 0)
remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
To https://github.com/mickaelandrieu/PrestaShop.git
 ! [remote rejected]       fix/missing-trads -> fix/missing-trads (permission denied)
error: impossible de pousser des références vers 'https://github.com/mickaelandrieu/PrestaShop.git'

@Quetzacoalt91 Quetzacoalt91 merged commit 2cc304d into PrestaShop:develop Oct 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 23, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 23, 2017

Thank you @mickaelandrieu

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 23, 2017

Contributor

@Quetzacoalt91 this time we are good ... are we? :)

Contributor

mickaelandrieu commented Oct 23, 2017

@Quetzacoalt91 this time we are good ... are we? :)

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:fix/missing-trads branch Oct 23, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 23, 2017

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment