New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved loading of translations #8392

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Oct 4, 2017

Questions Answers
Branch? develop
Description? Load a translation involves a lot of select queries: in "prod" mode this is cached at first call, but in "dev" mode it's not, let's improve the perfs a little bit.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Forge? http://forge.prestashop.com/browse/BOGOSS-54
How to test? In "dev" mode, you should notice a drop of ~50% of database queries done to render the page, for instance in Information System page we go from 344 to 173 Database queries.

Important guidelines

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Oct 4, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/PrestaShopBundle/Translation/Loader/DatabaseTranslationLoader.php  1
- src/PrestaShopBundle/Translation/Loader/SqlTranslationLoader.php  1
- src/PrestaShopBundle/Entity/Repository/LangRepository.php  1
         

See the complete overview on Codacy

codacy-bot commented Oct 4, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/PrestaShopBundle/Translation/Loader/DatabaseTranslationLoader.php  1
- src/PrestaShopBundle/Translation/Loader/SqlTranslationLoader.php  1
- src/PrestaShopBundle/Entity/Repository/LangRepository.php  1
         

See the complete overview on Codacy

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 9, 2017

Member

develop:
capture du 2017-10-09 16-42-31
#8392:
capture du 2017-10-09 16-39-39

Member

Quetzacoalt91 commented Oct 9, 2017

develop:
capture du 2017-10-09 16-42-31
#8392:
capture du 2017-10-09 16-39-39

@Quetzacoalt91 Quetzacoalt91 merged commit 435a9fd into PrestaShop:develop Oct 9, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 9, 2017

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:perfs/improve-translations-loading branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment