New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation domains to legacy templates #8395

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
2 participants
@AlexEven
Contributor

AlexEven commented Oct 5, 2017

Questions Answers
Branch? develop.
Description? Adding more domains to legacy strings to get rid of the "messages" domain.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a.
How to test? Check string catalog)

@AlexEven AlexEven added the WIP label Oct 5, 2017

@AlexEven AlexEven added this to the 1.7.3.0 milestone Oct 5, 2017

@AlexEven AlexEven changed the title from BO: Add translation domains to legacy templates to Add translation domains to legacy templates Oct 5, 2017

@AlexEven AlexEven removed the WIP label Oct 5, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 6, 2017

Member

Functional tests currently fails because of an error 500 on AdminDashboard.

localhost:80 127.0.0.1 - - [06/Oct/2017:08:33:57 +0000] "GET /admin-dev/index.php?controller=AdminDashboard&token=ebbd0bec73643473e1bb91b9c96a7567 HTTP/1.1" 500 39552 "http://localhost/admin-dev/index.php?controller=AdminLogin&token=84641a07ba47f3cb2d8c073d49aed6f3" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36"

Member

Quetzacoalt91 commented Oct 6, 2017

Functional tests currently fails because of an error 500 on AdminDashboard.

localhost:80 127.0.0.1 - - [06/Oct/2017:08:33:57 +0000] "GET /admin-dev/index.php?controller=AdminDashboard&token=ebbd0bec73643473e1bb91b9c96a7567 HTTP/1.1" 500 39552 "http://localhost/admin-dev/index.php?controller=AdminLogin&token=84641a07ba47f3cb2d8c073d49aed6f3" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36"

@Quetzacoalt91

We have a fatal error to fix

@Quetzacoalt91 Quetzacoalt91 merged commit e614e57 into PrestaShop:develop Oct 9, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment