New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PrestaShop deps: Symfony3, PHP 5.6 and PHPUnit 5.7 #8405

Merged
merged 7 commits into from Nov 16, 2017

Conversation

Projects
None yet
6 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Oct 9, 2017

Questions Answers
Branch? develop
Description? Update PrestaShop deps: Symfony3, PHP 5.6 and PHPUnit 5.7
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOGOSS-56
How to test? Travis test suite + visit all pages already migrated to Symfony

sf3_develop

Note 8/11 : capture update with new debug toolbar

Important guidelines


This change is Reviewable

@mickaelandrieu mickaelandrieu added this to the 1.7.4.0 milestone Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from prestonBot Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 9, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 10, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 10, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 10, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 10, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 10, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 10, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 10, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 10, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 11, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 11, 2017

@mickaelandrieu mickaelandrieu changed the title from Symfony 3 migration to [WIP] Symfony 3 migration Oct 11, 2017

Show outdated Hide outdated install-dev/init.php Outdated
@@ -55,9 +55,10 @@ public function testLoad()
$this->assertTrue(class_exists('RequestSql', false));
}
public function testClassLoadedFromCoreDir()
public function testClassFromCoreDirShouldntBeLoaded()

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 11, 2017

Contributor

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 12, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 12, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 12, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Oct 12, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 13, 2017

Member

I just had a look on the Travis logs. It's hidden in the whole log files, but the product page seems to be broken:

localhost:80 127.0.0.1 - - [12/Oct/2017:20:21:07 +0000] "GET /admin-dev/index.php/product/form/8?_token=9K90RRSDZZICKtPlDBNJ27Lw7duw-zve4mE8eRKKEw8 HTTP/1.1" 500 27059 "http://localhost/admin-dev/index.php/product/catalog?_token=9K90RRSDZZICKtPlDBNJ27Lw7duw-zve4mE8eRKKEw8" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36"
https://travis-ci.org/PrestaShop/PrestaShop/jobs/287232660#L3247

Member

Quetzacoalt91 commented Oct 13, 2017

I just had a look on the Travis logs. It's hidden in the whole log files, but the product page seems to be broken:

localhost:80 127.0.0.1 - - [12/Oct/2017:20:21:07 +0000] "GET /admin-dev/index.php/product/form/8?_token=9K90RRSDZZICKtPlDBNJ27Lw7duw-zve4mE8eRKKEw8 HTTP/1.1" 500 27059 "http://localhost/admin-dev/index.php/product/catalog?_token=9K90RRSDZZICKtPlDBNJ27Lw7duw-zve4mE8eRKKEw8" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36"
https://travis-ci.org/PrestaShop/PrestaShop/jobs/287232660#L3247

@@ -64,7 +64,7 @@ public function getHookParameters()
$sfContainer = SymfonyContainer::getInstance();
if (!is_null($sfContainer) && !is_null($sfContainer->get('request_stack')->getCurrentRequest())) {
$globalParameters['request'] = $sfContainer->get('request');
$globalParameters['request'] = $sfContainer->get('request_stack')->getCurrentRequest();

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Oct 13, 2017

Member

This comment has been minimized.

@Quetzacoalt91
@Quetzacoalt91

Quetzacoalt91 Oct 13, 2017

Member

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 13, 2017

Contributor

yes we need to apply this change too, request service is not available anymore

@mickaelandrieu

mickaelandrieu Oct 13, 2017

Contributor

yes we need to apply this change too, request service is not available anymore

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 6, 2017

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Nov 6, 2017

Contributor

:lgtm:


Reviewed 198 of 269 files at r1, 19 of 33 files at r2, 17 of 20 files at r3, 2 of 3 files at r4, 1 of 2 files at r5, 41 of 41 files at r6, 3 of 3 files at r7.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

Contributor

LittleBigDev commented Nov 6, 2017

:lgtm:


Reviewed 198 of 269 files at r1, 19 of 33 files at r2, 17 of 20 files at r3, 2 of 3 files at r4, 1 of 2 files at r5, 41 of 41 files at r6, 3 of 3 files at r7.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Nov 6, 2017

Contributor

I'm not approving yet, because there is still a blocking comment from @Quetzacoalt91 (in Reviewable)
But LGTM :)

Contributor

LittleBigDev commented Nov 6, 2017

I'm not approving yet, because there is still a blocking comment from @Quetzacoalt91 (in Reviewable)
But LGTM :)

@LittleBigDev LittleBigDev added the WIP label Nov 7, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 7, 2017

Member

The change I requested is done.

Member

Quetzacoalt91 commented Nov 7, 2017

The change I requested is done.

@LittleBigDev LittleBigDev removed the WIP label Nov 7, 2017

@mickaelandrieu mickaelandrieu dismissed stale reviews from LittleBigDev and Quetzacoalt91 via f335af4 Nov 8, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 8, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 8, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 8, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 8, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Nov 8, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 7
           

Complexity increasing per file
==============================
- app/AppKernel.php  4
- src/PrestaShopBundle/Event/Dispatcher/NullDispatcher.php  1
- tests/Integration/PrestaShopBundle/Service/DataProvider/MarketPlace/ApiClientTest.php  1
- src/Adapter/HookManager.php  1
         

Complexity decreasing per file
==============================
+ tests/Integration/PrestaShopBundle/Controller/Api/FeatureControllerTest.php  -1
+ tests/Integration/PrestaShopBundle/Controller/Api/AttributeControllerTest.php  -1
         

See the complete overview on Codacy

codacy-bot commented Nov 8, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 7
           

Complexity increasing per file
==============================
- app/AppKernel.php  4
- src/PrestaShopBundle/Event/Dispatcher/NullDispatcher.php  1
- tests/Integration/PrestaShopBundle/Service/DataProvider/MarketPlace/ApiClientTest.php  1
- src/Adapter/HookManager.php  1
         

Complexity decreasing per file
==============================
+ tests/Integration/PrestaShopBundle/Controller/Api/FeatureControllerTest.php  -1
+ tests/Integration/PrestaShopBundle/Controller/Api/AttributeControllerTest.php  -1
         

See the complete overview on Codacy

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 11, 2017

Contributor

@Quetzacoalt91 now 1.7.3.x branch is done, is there anything that block the merge of Symfony 3 migration ? We'll have ~6 months to fix any related issues :)

Contributor

mickaelandrieu commented Nov 11, 2017

@Quetzacoalt91 now 1.7.3.x branch is done, is there anything that block the merge of Symfony 3 migration ? We'll have ~6 months to fix any related issues :)

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Nov 16, 2017

Member

:lgtm:


Reviewed 1 of 269 files at r1, 1 of 2 files at r5, 5 of 6 files at r8, 6 of 6 files at r9.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

Member

eternoendless commented Nov 16, 2017

:lgtm:


Reviewed 1 of 269 files at r1, 1 of 2 files at r5, 5 of 6 files at r8, 6 of 6 files at r9.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Nov 16, 2017

Thank you @mickaelandrieu 🎉

@eternoendless eternoendless merged commit 90d396f into PrestaShop:develop Nov 16, 2017

2 of 3 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
code-review/reviewable 208 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
<li>
PrestaShop installation needs to write critical files in the folder app/cache.
PrestaShop installation needs to write critical files in the folder app/var.

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Jan 19, 2018

Member

Wrong, needs to be fixed

@Quetzacoalt91

Quetzacoalt91 Jan 19, 2018

Member

Wrong, needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment