New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run web installation with functional tests #8412

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 12, 2017

Questions Answers
Branch? develop
Description? Sometimes, new PRs brings issues only detected during the installation via web. The current tests with tries the CLI one, which lets some issues going through the whole testing process. This PR brings a new step in the functional tests.
Type? improvement
Category? TE
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Check travis build with additional tests.

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 added the WIP label Oct 19, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 20, 2017

Member

Hello @fatmaBouchekoua, in order to add the functional tests on the PrestaShop I actually need to customize the server address and the user / password used. It would be great if you can add these tweaks.

You chose the way we set the variables for you (environment variables, command parameters etc.).

Member

Quetzacoalt91 commented Oct 20, 2017

Hello @fatmaBouchekoua, in order to add the functional tests on the PrestaShop I actually need to customize the server address and the user / password used. It would be great if you can add these tweaks.

You chose the way we set the variables for you (environment variables, command parameters etc.).

@Quetzacoalt91 Quetzacoalt91 removed the WIP label Nov 17, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 17, 2017

Member

The last issue on the functional tests has been fixed and this PR is now ready for review.

Member

Quetzacoalt91 commented Nov 17, 2017

The last issue on the functional tests has been fixed and this PR is now ready for review.

@mickaelandrieu mickaelandrieu merged commit 23d2754 into PrestaShop:develop Nov 22, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu
Contributor

mickaelandrieu commented Nov 22, 2017

Thanks @Quetzacoalt91 !

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:install-ps-in-functionnal-tests branch Nov 28, 2017

@eternoendless eternoendless added this to the 1.7.4.0 milestone Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment