New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the button of add a new customization field in the product page #8414

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
3 participants
@Azouz-Jribi
Contributor

Azouz-Jribi commented Oct 13, 2017

Questions Answers
Branch? develop
Description? When we click on the "add a customization field" button, the form won't display.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? none
How to test? BO > Catalog > Products > edit product > Options tab, try to add a customization field and check if the form is well displayed.

This change is Reviewable

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Oct 13, 2017

Member

This fixes a regression that was introduced in this commit: 74b6d3e#diff-14d02a032fea6da674ba95e0e56c9516R892

Member

eternoendless commented Oct 13, 2017

This fixes a regression that was introduced in this commit: 74b6d3e#diff-14d02a032fea6da674ba95e0e56c9516R892

@eternoendless

Code looks good!

@eternoendless eternoendless added this to the 1.7.3.0 milestone Oct 13, 2017

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 13, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Oct 13, 2017

Thank you @Azouz-Jribi

@eternoendless eternoendless merged commit e0b1a01 into PrestaShop:develop Oct 13, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment