New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove product description length limit #8415

Merged
merged 2 commits into from Oct 20, 2017

Conversation

Projects
None yet
5 participants
@maxime-aknin
Contributor

maxime-aknin commented Oct 13, 2017

Do not limit product description's length

Questions? Answers
Branch? 1.7.x
Description? Product description length limit is hard coded to 6000 characters.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? --
How to test? Try to save a description with more than 6000 characters.

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Oct 13, 2017

Collaborator

Hello maxime-aknin!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Oct 13, 2017

Hello maxime-aknin!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@maxime-aknin maxime-aknin changed the title from Remove product description length limit to BO: Remove product description length limit Oct 13, 2017

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Oct 16, 2017

Contributor

Hey @maxime-aknin, thanks for the PR!
I'm unsure about the implications of such a change, none the less with the database.
@eternoendless, what do you think?

Contributor

xBorderie commented Oct 16, 2017

Hey @maxime-aknin, thanks for the PR!
I'm unsure about the implications of such a change, none the less with the database.
@eternoendless, what do you think?

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Oct 19, 2017

Member

Thanks for this contribution, however we cannot merge it as-is. You can learn more about why this limit was introduced here: #7817

This limit can (and should) be upped to 21844 – the maximum safe limit for the TEXT field on MySQL using UTF-8 characters. Anything longer than that may be truncated by MySQL, depending on the characters used.

Member

eternoendless commented Oct 19, 2017

Thanks for this contribution, however we cannot merge it as-is. You can learn more about why this limit was introduced here: #7817

This limit can (and should) be upped to 21844 – the maximum safe limit for the TEXT field on MySQL using UTF-8 characters. Anything longer than that may be truncated by MySQL, depending on the characters used.

@eternoendless

The limit needs to be kept

@eternoendless eternoendless added this to the 1.7.3.0 milestone Oct 19, 2017

@eternoendless eternoendless changed the title from BO: Remove product description length limit to Remove product description length limit Oct 19, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Oct 20, 2017

Thank you @maxime-aknin

@eternoendless eternoendless merged commit 9d2a6da into PrestaShop:develop Oct 20, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxime-aknin maxime-aknin deleted the maxime-aknin:patch-1 branch Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment