New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display properly ps_linklist on classic with widgets #8416

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 13, 2017

Questions Answers
Branch? develop
Description? When you use the widget feature with the module ps_linklist, the links were not properly displayed with the anti-collapse style only applied to the footer.
Type? bug fix
Category? FO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3180
How to test? As describe in the Jira issue, hook the module ps_linklist on different positions of the front office, check if the links list appears anyway.

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 30, 2017

Contributor

@Quetzacoalt91 would you mind to rebase your pull request? Then I can merge (no need QA validation).

Contributor

mickaelandrieu commented Oct 30, 2017

@Quetzacoalt91 would you mind to rebase your pull request? Then I can merge (no need QA validation).

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 30, 2017

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 31, 2017

Contributor

Thanks! Good job mate

Contributor

mickaelandrieu commented Oct 31, 2017

Thanks! Good job mate

@mickaelandrieu mickaelandrieu merged commit 0b66336 into PrestaShop:develop Oct 31, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.3.0 milestone Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment