New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing cache invalidation in the backoffice #8417

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
4 participants
@jocel1
Contributor

jocel1 commented Oct 14, 2017

execute* function should be used instead, to properly invalidates the cache

Questions Answers
Branch? develop
Description? fix missing cache invalidation in the backoffice
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Enable the cache, (for example memcached). Go into a category in the front office, to cache the info. Then go the BO and change a position of a product in this category. Check the new position is properly reflected in the front office.

This change is Reviewable

fix wrong usage of query function.
execute* function should be used instead, to properly invalidates the cache

@jocel1 jocel1 requested a review from eternoendless Oct 14, 2017

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Oct 14, 2017

Collaborator

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`fix wrong usage of query function. execute* function should be used instead, to properly invalidates the cache` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

example

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Collaborator

prestonBot commented Oct 14, 2017

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`fix wrong usage of query function. execute* function should be used instead, to properly invalidates the cache` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

example

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@jocel1 jocel1 added the Bug label Oct 14, 2017

@Quetzacoalt91

Thank you @jocel1

@Quetzacoalt91 Quetzacoalt91 merged commit 9ed63cd into PrestaShop:develop Oct 18, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xBorderie xBorderie added this to the 1.7.3.0 milestone Oct 24, 2017

@eternoendless eternoendless changed the title from fix missing cache invalidation in the backoffice to Fix missing cache invalidation in the backoffice Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment