New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid selector on feature removal (Product page) #8436

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
4 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Oct 24, 2017

Questions Answers
Branch? develop
Description? On feature(s) removal, all features were removed when we clicked on one of them. It's now fixed.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3889
How to test? Try to delete a feature on Product Page before and after this patch.

Important guidelines


This change is Reviewable

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Oct 24, 2017

Contributor

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Contributor

LittleBigDev commented Oct 24, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@LittleBigDev

Thanks @mickaelandrieu . Looks good to me.

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Oct 25, 2017

Contributor

@mickaelandrieu
Same strange behavior as for the preview button.

Contributor

marionf commented Oct 25, 2017

@mickaelandrieu
Same strange behavior as for the preview button.

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Oct 25, 2017

Contributor

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

Contributor

LittleBigDev commented Oct 25, 2017

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@LittleBigDev

Commit finally passed.
LGTM again.

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 31, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 31, 2017

Member

Okay for this PR.
However, did you see that adding a feature is impossible? Even if you see a successful save, refreshing the product make the feature disappear.

@vincentbz

Member

Quetzacoalt91 commented Oct 31, 2017

Okay for this PR.
However, did you see that adding a feature is impossible? Even if you see a successful save, refreshing the product make the feature disappear.

@vincentbz

@Quetzacoalt91 Quetzacoalt91 merged commit 913391e into develop Oct 31, 2017

3 of 4 checks passed

code-review/reviewable 1 discussion left (Quetzacoalt91)
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the fix/boom-3889 branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment