New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid path to look at config.defines.inc file permissions #8440

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Oct 25, 2017

Questions Answers
Branch? develop
Description? In debug mode, you can't update debug mode because PrestaShop look at config.defines.php file into the wrong folder.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? None, but it's part of Performance page migration :)
How to test? Switch into dev mode, then prod mode, then dev mode again. Note this is not a regression as "before" the migration the file perms were just "ignored" ...

Important guidelines


This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 26, 2017

Contributor

@PrestaShop/prestashop-core-dev this doesnt need any validation, can someone merge this one please?
thanks!

Contributor

mickaelandrieu commented Oct 26, 2017

@PrestaShop/prestashop-core-dev this doesnt need any validation, can someone merge this one please?
thanks!

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 30, 2017

Member

We have two config folder, config/ and app/config/, how can we be sure that relying on the other one won't break something else?

Member

Quetzacoalt91 commented Oct 30, 2017

We have two config folder, config/ and app/config/, how can we be sure that relying on the other one won't break something else?

@Quetzacoalt91 Quetzacoalt91 modified the milestones: 1.7.4.0, 1.7.3.0 Oct 31, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit f0b1154 into PrestaShop:develop Oct 31, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:fix/invalid-config-folder branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment