New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sorting problem with a descending order in the products filtering page #8445

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
6 participants
@Azouz-Jribi
Contributor

Azouz-Jribi commented Oct 27, 2017

Questions Answers
Branch? 1.6.1x
Description? When blocklayered is enabled, the sorting in descending order does not work in the products filtering page.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-8185
How to test? FO > the products filtering page, sort the products with any filter in descending order (example : Product Name: Z to A) and check if you get the right result.

This change is Reviewable

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Nov 7, 2017

Contributor

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Contributor

LittleBigDev commented Nov 7, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@illjah42

This comment has been minimized.

Show comment
Hide comment
@illjah42

illjah42 Jan 5, 2018

Thanks for fixing! Best wishes!

illjah42 commented Jan 5, 2018

Thanks for fixing! Best wishes!

@Quetzacoalt91 Quetzacoalt91 added this to the 1.6.1.18 milestone Jan 5, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit f36cfcb into PrestaShop:1.6.1.x Jan 5, 2018

3 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/reviewable 1 file reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Jan 5, 2018

Thank you @Azouz-Jribi

@Azouz-Jribi

This comment has been minimized.

Show comment
Hide comment
@Azouz-Jribi

Azouz-Jribi Jan 22, 2018

Contributor

Hello @Quetzacoalt91
you have to merge this PR (PrestaShop/blocklayered#117), because it is related.

Contributor

Azouz-Jribi commented Jan 22, 2018

Hello @Quetzacoalt91
you have to merge this PR (PrestaShop/blocklayered#117), because it is related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment