New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cover to allowed properties in ajax requests #8447

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
5 participants
@iqit-commerce
Contributor

iqit-commerce commented Oct 29, 2017

Cover attribute is widely used by theme developers for ajax search

Questions Answers
Branch? develop
Description? Latest upgrade 1.7.2.4 added PR #8433 which remove some data from ajax query. It also removed cover attribute
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

Important guidelines


This change is Reviewable

Add cover to allowed properties in ajax requests
Cover attribute is widely used by theme developers for ajax search
@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Oct 29, 2017

Collaborator

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`Add cover to allowed properties in ajax requests

Cover attribute is widely used by theme developers for ajax search` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

example

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Collaborator

prestonBot commented Oct 29, 2017

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`Add cover to allowed properties in ajax requests

Cover attribute is widely used by theme developers for ajax search` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

example

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@Quetzacoalt91 Quetzacoalt91 requested a review from eternoendless Oct 31, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 31, 2017

Member

I'm cool with that change. @kompilorb and/or @eternoendless?

Member

Quetzacoalt91 commented Oct 31, 2017

I'm cool with that change. @kompilorb and/or @eternoendless?

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 31, 2017

@iqit-commerce

This comment has been minimized.

Show comment
Hide comment
@iqit-commerce

iqit-commerce Oct 31, 2017

Contributor

@Quetzacoalt91 Great and thanks for fast reaction! Is estimation date for 1.7.3 is known?

Contributor

iqit-commerce commented Oct 31, 2017

@Quetzacoalt91 Great and thanks for fast reaction! Is estimation date for 1.7.3 is known?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 2, 2017

Member

Unfortunately I don't have any ETA yet. :(

Member

Quetzacoalt91 commented Nov 2, 2017

Unfortunately I don't have any ETA yet. :(

@toutantic toutantic merged commit 46479d2 into PrestaShop:develop Nov 6, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment