New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog controler wrongly use by default desc sorting instead of "last" #8452

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@jocel1
Contributor

jocel1 commented Oct 30, 2017

Questions Answers
Branch? develop
Description? When sorting by position asc is enabled in the product catalog and the position is changed, the sorting is reset to desc after hitting save & refresh
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? After hitting save & refresh the sorting should remain the same

Important guidelines


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Oct 30, 2017

Collaborator

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`Catalog controler wrongly use by default desc sorting instead of "last"` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

example

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Collaborator

prestonBot commented Oct 30, 2017

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`Catalog controler wrongly use by default desc sorting instead of "last"` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

example

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@jocel1 jocel1 requested a review from mickaelandrieu Oct 31, 2017

@Quetzacoalt91 Quetzacoalt91 changed the base branch from 1.7.2.x to develop Oct 31, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit c49560e into PrestaShop:develop Oct 31, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 31, 2017

Thank you @jocel1

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment