New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve order presenter performance #8453

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@sarjon
Member

sarjon commented Oct 30, 2017

Questions Answers
Branch? develop
Description? Improves order presenter performance since $this->getProducts() (which performs a lot of processing) was called second time just to get number of products.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? See PR.

This change is Reviewable

@Quetzacoalt91

Thank you @sarjon

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 31, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 4d0dba0 into PrestaShop:develop Oct 31, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless changed the title from CO: Improve order presenter performance to Improve order presenter performance Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment