New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make urls available on maintenance & restricted country templates #8455

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@kpodemski
Contributor

kpodemski commented Oct 31, 2017

Questions Answers
Branch? develop
Description? enable maintenance, enable debug mode, wrong, $urls not available
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? maybe
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 31, 2017

Member

Hello @kpodemski,

As we do not have these notices on the classic theme, can you please tell us how to reproduce your issue?
Thanks

Member

Quetzacoalt91 commented Oct 31, 2017

Hello @kpodemski,

As we do not have these notices on the classic theme, can you please tell us how to reproduce your issue?
Thanks

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Nov 2, 2017

Contributor

Hello @Quetzacoalt91

try to use $urls.something in maintenance.tpl, you just can't because these vars are not available and for example we can't link to images etc.

Contributor

kpodemski commented Nov 2, 2017

Hello @Quetzacoalt91

try to use $urls.something in maintenance.tpl, you just can't because these vars are not available and for example we can't link to images etc.

@Quetzacoalt91

Quetzacoalt91 approved these changes Nov 6, 2017 edited

Well, I have no blocking issue regarding this change. However, this is more a improvement than a bug fix.

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Nov 6, 2017

@Quetzacoalt91 Quetzacoalt91 changed the title from Fix notice error on maintenance page to Make urls available on maintenance & restricted country templates Nov 6, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit a50696b into PrestaShop:develop Nov 6, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment