New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force query build arg_separator to & #8459

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
3 participants
@tonyyb

tonyyb commented Nov 2, 2017

Questions Answers
Branch? develop
Description? The http_build_query uses by default the arg_separator.output value of PHP. So we have to force it because in some cases the default arg_separator.output is : &
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? You can reproduce this bug only if "arg_separator.output" is defined to "&" in your php configuration.Try a phpinfo(), I think you have "&" value configured. After your "arg_separator.output" defined to "&" you can reproduce this bug on AdminTranslations back office page. Try to update translations of classic template : unable to access (browser error)

Similar to #7779 : fixed some time ago.


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 2, 2017

Collaborator

Hello tonyyb!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Nov 2, 2017

Hello tonyyb!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Nov 6, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit cbc01c2 into PrestaShop:develop Nov 6, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 6, 2017

Member

Thank you @tonyyb

Member

Quetzacoalt91 commented Nov 6, 2017

Thank you @tonyyb

@eternoendless eternoendless changed the title from CO: force query build arg_separator to & to Force query build arg_separator to & Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment