New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing data duplication when using 1-click upgrade multiple times #8461

Merged
merged 4 commits into from Nov 6, 2017

Conversation

Projects
None yet
5 participants
@LittleBigDev
Contributor

LittleBigDev commented Nov 2, 2017

Questions Answers
Branch? develop
Description? When using 1-click upgrade multiple times, an "AdminStockManagement" menu is duplicated again and again. Maybe other data is duplicated too (this bug is hard to reproduce)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? BOOM-3961
How to test? Install a PS version before ASM was re-introduced. Using 1-click upgrade module: Upgrade and keep upgrading for every minor version. Duplicated tab and other duplicated data should not appear anymore after applying this fix.

This change is Reviewable

@LittleBigDev LittleBigDev changed the title from WIP: Fixing data duplication when using 1-click upgrade multiple times to Fixing data duplication when using 1-click upgrade multiple times Nov 2, 2017

@LittleBigDev LittleBigDev added this to the 1.7.3.0 milestone Nov 2, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 2, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 3, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Nov 3, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- install-dev/upgrade/php/add_new_status_stock.php  3
         

See the complete overview on Codacy

codacy-bot commented Nov 3, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- install-dev/upgrade/php/add_new_status_stock.php  3
         

See the complete overview on Codacy

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 3, 2017

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 6, 2017

Contributor

Approval of @Quetzacoalt91 + mine + tests OK => LGTM

Contributor

mickaelandrieu commented Nov 6, 2017

Approval of @Quetzacoalt91 + mine + tests OK => LGTM

@mickaelandrieu mickaelandrieu merged commit a1d52c5 into PrestaShop:develop Nov 6, 2017

2 of 3 checks passed

code-review/reviewable 1 file, 2 discussions left (LittleBigDev, Quetzacoalt91)
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@LittleBigDev LittleBigDev deleted the LittleBigDev:BOOM-3961-multiple-adminstockmanagement-tabs branch Nov 7, 2017

@kanecko

This comment has been minimized.

Show comment
Hide comment
@kanecko

kanecko Dec 5, 2017

Will this fix reverse the duplications?
What's best-practice to remove the duplicated menu items?

kanecko commented Dec 5, 2017

Will this fix reverse the duplications?
What's best-practice to remove the duplicated menu items?

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Dec 5, 2017

Contributor

Hello @kanecko ,

Duplications will not be reversed by this fix.
If you need to remove unwanted tabs, you will first need to BACKUP your database.
Then you will need to inspect the menu tab's <li> elements and pick their data-submenu attribute. This number is the ps_tab.id_tab column in database. It identifies the unwanted tab in this table.
Make sure you are not creating orphan tabs when deleting this line from ps_tab table.

If you are not comfortable with manual data manipulation, I can create an SQL script that will take care of it for you. But I lack time right now. Sorry...

Contributor

LittleBigDev commented Dec 5, 2017

Hello @kanecko ,

Duplications will not be reversed by this fix.
If you need to remove unwanted tabs, you will first need to BACKUP your database.
Then you will need to inspect the menu tab's <li> elements and pick their data-submenu attribute. This number is the ps_tab.id_tab column in database. It identifies the unwanted tab in this table.
Make sure you are not creating orphan tabs when deleting this line from ps_tab table.

If you are not comfortable with manual data manipulation, I can create an SQL script that will take care of it for you. But I lack time right now. Sorry...

@kanecko

This comment has been minimized.

Show comment
Hide comment
@kanecko

kanecko Dec 6, 2017

I'll try it out manually, thanks for your explanation.

kanecko commented Dec 6, 2017

I'll try it out manually, thanks for your explanation.

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Dec 6, 2017

Contributor

You're welcome :)

Contributor

LittleBigDev commented Dec 6, 2017

You're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment