New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless method from Customer class #8465

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
4 participants
@tonyyb

tonyyb commented Nov 3, 2017

Questions Answers
Branch? develop
Description? toggleStatus() already update date_upd in ObjectModelCore by calling $this->update(false)
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Remove the method and see that date_upd still updated after customer' status change.

See #8464


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 3, 2017

Collaborator

Hello tonyyb!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Nov 3, 2017

Hello tonyyb!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Nov 3, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Nov 3, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ classes/Customer.php  -1
         

See the complete overview on Codacy

codacy-bot commented Nov 3, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ classes/Customer.php  -1
         

See the complete overview on Codacy

@Quetzacoalt91 Quetzacoalt91 merged commit 98da2d7 into PrestaShop:develop Nov 3, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 3, 2017

Member

Thank you @tonyyb

Member

Quetzacoalt91 commented Nov 3, 2017

Thank you @tonyyb

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Nov 3, 2017

delete it

ghost commented Nov 3, 2017

delete it

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 6, 2017

Member

You mean your message? That'd be better

Member

Quetzacoalt91 commented Nov 6, 2017

You mean your message? That'd be better

@PrestaShop PrestaShop locked and limited conversation to collaborators Nov 6, 2017

@eternoendless eternoendless changed the title from [CO] Remove useless method from Customer class to Remove useless method from Customer class Dec 7, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.