New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized Debug toolbar with PrestaShop application information #8472

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Nov 7, 2017

Questions Answers
Branch? develop
Description? Make debug toolbar display information about PrestaShop version and documentation instead of Symfony
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? none
How to test? See screenshots

prestashop-profiler

block_opened

Important guidelines


This change is Reviewable

@mickaelandrieu mickaelandrieu changed the title from Customized Debug toolbar as PrestaShop toolbar to Customized Debug toolbar with PrestaShop application information Nov 7, 2017

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev
Contributor

LittleBigDev commented Nov 7, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 7, 2017

Member

OH YES, the missing information!

Member

Quetzacoalt91 commented Nov 7, 2017

OH YES, the missing information!

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 7, 2017

Contributor

Hello @mickaelandrieu, a unit test is failing : https://travis-ci.org/PrestaShop/PrestaShop/jobs/298303693#L928

yes... but don't know why... the debug toolbar is not display on AdminCartsController

edit: fixed relaunching test suite

Contributor

mickaelandrieu commented Nov 7, 2017

Hello @mickaelandrieu, a unit test is failing : https://travis-ci.org/PrestaShop/PrestaShop/jobs/298303693#L928

yes... but don't know why... the debug toolbar is not display on AdminCartsController

edit: fixed relaunching test suite

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 7, 2017

Member

Now we have the PrestaShop version 2 times, but can we still have the Symfony version installed as well?

Member

Quetzacoalt91 commented Nov 7, 2017

Now we have the PrestaShop version 2 times, but can we still have the Symfony version installed as well?

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Nov 7, 2017

Contributor

It will depend on PS version anyway (1 SF version = 1 PS version)
Edit : or am I wrong ??? :O

Contributor

LittleBigDev commented Nov 7, 2017

It will depend on PS version anyway (1 SF version = 1 PS version)
Edit : or am I wrong ??? :O

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 7, 2017

Member

This information could be useful for module developers, and for us. We won't need to reinstall a previous version of PresteShop just for having the related Symfony version.

Member

Quetzacoalt91 commented Nov 7, 2017

This information could be useful for module developers, and for us. We won't need to reinstall a previous version of PresteShop just for having the related Symfony version.

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 7, 2017

Contributor

@Quetzacoalt91 you still have it

sf_version

but still, I've improved the block, wdyt?

Contributor

mickaelandrieu commented Nov 7, 2017

@Quetzacoalt91 you still have it

sf_version

but still, I've improved the block, wdyt?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 7, 2017

Member

All good for me, thanks!

Member

Quetzacoalt91 commented Nov 7, 2017

All good for me, thanks!

@Quetzacoalt91 Quetzacoalt91 merged commit 4345762 into PrestaShop:develop Nov 7, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:feat/prestashop-profiler branch Nov 7, 2017

@eternoendless eternoendless added this to the 1.7.3.0 milestone Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment