New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old emailing category #8479

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
3 participants
@robbie-thompson
Contributor

robbie-thompson commented Nov 8, 2017

Questions Answers
Branch? develop
Description? The emailing module category was being defined twice in the admin modules controller. This fix removes the old definition, as it is already being overwritten later in the code and is therefore unnecessary.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Load the modules list in the BO and see that the new name is still being used for the emailing category.

Important guidelines


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 8, 2017

Collaborator

Hello robbie-thompson!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Nov 8, 2017

Hello robbie-thompson!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 8, 2017

Thank you @robbie-thompson

@Quetzacoalt91 Quetzacoalt91 merged commit 2dae900 into PrestaShop:develop Nov 8, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.4.0 milestone Nov 8, 2017

@robbie-thompson robbie-thompson deleted the robbie-thompson:fix/email-category-duplicate branch Nov 8, 2017

@eternoendless eternoendless changed the title from BO: Removed old emailing category to Removed old emailing category Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment