New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display error if AdminShopGroup doesn't exist #8481

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@rGaillard
Member

rGaillard commented Nov 8, 2017

Questions Answers
Branch? develop
Description? if the tab AdminShopGroup don't exist, it will try to update an empty tab
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? delete the AdminShopGroup tab and try to save the AdminPreference tab

This change is Reviewable

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Nov 13, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- controllers/admin/AdminPreferencesController.php  1
         

See the complete overview on Codacy

codacy-bot commented Nov 13, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- controllers/admin/AdminPreferencesController.php  1
         

See the complete overview on Codacy

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 13, 2017

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.4.0 milestone Nov 13, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit d564c3c into PrestaShop:develop Nov 13, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 13, 2017

Thank you @rGaillard

@eternoendless eternoendless changed the title from BO: don't display error if AdminShopGroup doesn't exist to Don't display error if AdminShopGroup doesn't exist Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment