New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in ControllerCore and AbstractFormCore #8486

Merged
merged 4 commits into from Nov 13, 2017

Conversation

Projects
None yet
4 participants
@mnastalski
Contributor

mnastalski commented Nov 11, 2017

Questions Answers
Branch? develop
Description? Improved code quality in ControllerCore and AbstractFormCore
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? -

Important guidelines


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 11, 2017

Collaborator

Hello mnastalski!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Nov 11, 2017

Hello mnastalski!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 11, 2017

Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Collaborator

prestonBot commented Nov 11, 2017

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@Quetzacoalt91

I'm good with this refacto 👍

Would you mind replacing the array creation with the long syntax. i.e array($js_uri) instead of [$js_uri].

Thanks a lot!

@mnastalski

This comment has been minimized.

Show comment
Hide comment
@mnastalski
Contributor

mnastalski commented Nov 13, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Nov 13, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ classes/controller/Controller.php  -2
         

See the complete overview on Codacy

codacy-bot commented Nov 13, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ classes/controller/Controller.php  -2
         

See the complete overview on Codacy

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 13, 2017

@Quetzacoalt91

Thank you sir

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.4.0 milestone Nov 13, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 1328a28 into PrestaShop:develop Nov 13, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mnastalski mnastalski deleted the mnastalski:code-refactor branch Nov 16, 2017

@prestonBot prestonBot added the develop label Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment