New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robots.txt, exclude order param #8488

Merged
merged 2 commits into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@prestarocket
Contributor

prestarocket commented Nov 13, 2017

Questions Answers
Branch? develop
Description? The new param for ordering in ps 1.7 is order, not anymore orderby.
Robots are actually indexing page with order in params, it could consume crawl budget
Orderway is also useless for 1.7
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? open robots.txt (http://fo.demo.prestashop.com/robots.txt), you will find Disallow: /*?orderby=
Now, order a product list page by price asc for ex. and you will see order in params

Important guidelines


This change is Reviewable

CO: fix robots.txt exclude order param
The new param for ordering in ps 1.7 is order, not anymore orderby.
Robots are actually indexing page with order in params, it could consume crawl budget 
Orderway is also useless for 1.7

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.4.0 milestone Nov 14, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 14, 2017

Member

Thank you @prestarocket,

Would you mind committing the equivalent robots.txt to the project please?

Member

Quetzacoalt91 commented Nov 14, 2017

Thank you @prestarocket,

Would you mind committing the equivalent robots.txt to the project please?

Update robots.txt
add disallow order & rm disallow orderway
@prestarocket

This comment has been minimized.

Show comment
Hide comment
@prestarocket
Contributor

prestarocket commented Nov 14, 2017

@Quetzacoalt91 done !!

@Quetzacoalt91

Perfect 👌

@Quetzacoalt91 Quetzacoalt91 merged commit ea81574 into PrestaShop:develop Nov 14, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 14, 2017

Thank you @prestarocket

@prestarocket

This comment has been minimized.

Show comment
Hide comment
@prestarocket

prestarocket Nov 14, 2017

Contributor

thx @Quetzacoalt91 , very fast approval; 👍

Contributor

prestarocket commented Nov 14, 2017

thx @Quetzacoalt91 , very fast approval; 👍

@eternoendless eternoendless changed the title from CO: fix robots.txt, exclude order param to Fix robots.txt, exclude order param Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment