New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1.7.3 into develop #8530

Merged
merged 91 commits into from Nov 22, 2017

Conversation

Projects
None yet
@mickaelandrieu
Contributor

mickaelandrieu commented Nov 22, 2017

Questions Answers
Branch? develop
Description? Synchronize develop with updates done in 1.7.3.x branch
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? I don't know

Important guidelines


This change is Reviewable

comxd and others added some commits Oct 8, 2017

Merge pull request #8471 from kpodemski/patch-12
Allow to sort bestsellers by sales
comxd
Merge pull request #8468 from tomlev/BOOM-4118
fix wrong typehinting on attribute prices
Merge pull request #8442 from mickaelandrieu/fix/hooks-duplication-pr…
…oduct-listing

Fixed duplication of hooks in pages migrated to Symfony
Merge pull request #8401 from comxd/patch-1
BO: Add a new hook on AdminCutomers view > Addresses actions
Merge pull request #8477 from mickaelandrieu/fix/add-hooks-on-product…
…-listing-page

Added displayDashboardToolbarTopMenu and displayDashboardToolbarIcons hooks
Fix search when using exact words (#8473)
* FO: Fix search when using exact words

* TE: Extract keyword generation for test
Merge pull request #8478 from kompilorb/1.7.3.x
Fix shopping cart when allow checkout with wrongly product
Merge pull request #8480 from mickaelandrieu/fix/docs-link-in-dtb
Fixed PrestaShop docs link in debug toolbar

kpodemski and others added some commits Nov 8, 2017

CO: fix robots.txt exclude order param
The new param for ordering in ps 1.7 is order, not anymore orderby.
Robots are actually indexing page with order in params, it could consume crawl budget 
Orderway is also useless for 1.7
Update robots.txt
add disallow order & rm disallow orderway

@Quetzacoalt91 Quetzacoalt91 merged commit a403d9f into PrestaShop:develop Nov 22, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maofree

This comment has been minimized.

Show comment
Hide comment
@maofree

maofree Nov 25, 2017

Hi
Can I know if this bug will be solved in a short time? because I think it is a big bug and I report it from many months. Nobody answer to the topic so I write here to get some info about that.

http://forge.prestashop.com/browse/BOOM-3195
after each 1.7 upgrades many modules lost their hooks in the front-office and it is necessary to reset them each time.

thanks
bye

maofree commented Nov 25, 2017

Hi
Can I know if this bug will be solved in a short time? because I think it is a big bug and I report it from many months. Nobody answer to the topic so I write here to get some info about that.

http://forge.prestashop.com/browse/BOOM-3195
after each 1.7 upgrades many modules lost their hooks in the front-office and it is necessary to reset them each time.

thanks
bye

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Nov 25, 2017

Contributor

@maofree i'm afraid that this is not going to be solved in 1.7.3... however...

@Quetzacoalt91 @mickaelandrieu

guys, if that's a case and people have this issue... i think that this is issue which needs to be fixed before releasing a new version, imagine all these people lost their module settings after an update... this would be a disaster

thoughts @eternoendless ?

Contributor

kpodemski commented Nov 25, 2017

@maofree i'm afraid that this is not going to be solved in 1.7.3... however...

@Quetzacoalt91 @mickaelandrieu

guys, if that's a case and people have this issue... i think that this is issue which needs to be fixed before releasing a new version, imagine all these people lost their module settings after an update... this would be a disaster

thoughts @eternoendless ?

@maofree

This comment has been minimized.

Show comment
Hide comment
@maofree

maofree Nov 25, 2017

ok thanks
at this moment I cannot upgrade to 1.7.x from 1.6 or start a new project with 1.7 to avoid this problem

maofree commented Nov 25, 2017

ok thanks
at this moment I cannot upgrade to 1.7.x from 1.6 or start a new project with 1.7 to avoid this problem

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 27, 2017

Member

We haven't confirmed yet, but this might be related to #8543. Fingers crossed!

Member

Quetzacoalt91 commented Nov 27, 2017

We haven't confirmed yet, but this might be related to #8543. Fingers crossed!

@eternoendless eternoendless added this to the 1.7.4.0 milestone Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment