Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DiscountController.php #8539

Closed
wants to merge 1 commit into from
Closed

Update DiscountController.php #8539

wants to merge 1 commit into from

Conversation

PrestaSafe
Copy link
Contributor

@PrestaSafe PrestaSafe commented Nov 23, 2017

Fixing issue http://forge.prestashop.com/browse/PSCSX-9616
For displaying discount in customer account (Discount front controller)


This change is Reviewable

Fixing issue http://forge.prestashop.com/browse/PSCSX-9616
For displaying discount in customer account (Discount front controller)
@prestonBot
Copy link
Collaborator

Hello guillaume23!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The description shouldn't be empty.
  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@mickaelandrieu
Copy link
Contributor

Hello @guillaume23,

we can't accept this kind of patch:

  • if the value expected is a boolean, please check on value and type on the true or false value.
  • f the vaue expected is an integer, your patch hide the error but don't fix it.

Also, we don't merge pull request with no description, so please take time to complete the pull request description with the required information.

Thank you!

@mickaelandrieu mickaelandrieu added Waiting for author Status: action required, waiting for author feedback 1.6.1.x labels Nov 23, 2017
@Matt75
Copy link
Contributor

Matt75 commented Nov 24, 2017

Already fixed in #8337
This is in the 1.6.1.18 milestone

@Quetzacoalt91
Copy link
Member

Uhuh nice @Matt75, thanks!

As we deal with a duplicate here, I close it. I hope to merge the other one is a short delay btw.
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for author Status: action required, waiting for author feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants