New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing Phpdoc in SpecificPrice #8546

Merged
merged 2 commits into from Nov 30, 2017

Conversation

Projects
None yet
5 participants
@infiniweb

infiniweb commented Nov 24, 2017

Questions Answers
Branch? develop
Description? Add some missing Phpdoc in SpecificPrice, especially for function "exists" that might be confusing to use without looking at the code
Type? improvement
Category? CO
BC breaks? no
Deprecations? no

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 24, 2017

Collaborator

Hello infiniweb!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Nov 24, 2017

Hello infiniweb!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Nov 24, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ classes/SpecificPrice.php  -70
         

See the complete overview on Codacy

codacy-bot commented Nov 24, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ classes/SpecificPrice.php  -70
         

See the complete overview on Codacy

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 30, 2017

Contributor

Thank you @infiniweb and welcome into the PrestaShop community :)

Contributor

mickaelandrieu commented Nov 30, 2017

Thank you @infiniweb and welcome into the PrestaShop community :)

@mickaelandrieu mickaelandrieu merged commit 73f4f66 into PrestaShop:develop Nov 30, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.4.0 milestone Apr 13, 2018

@eternoendless eternoendless changed the title from CO: Add some missing Phpdoc in SpecificPrice to Add some missing Phpdoc in SpecificPrice Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment