New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better performance in order template #8547

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
3 participants
@jkfran
Contributor

jkfran commented Nov 25, 2017

Questions Answers
Branch? develop
Description? Remove redundant code.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Compare times when loading an order.

Important guidelines


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 25, 2017

Collaborator

Hello jkfran!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Nov 25, 2017

Hello jkfran!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Quetzacoalt91

To be confirmed with a Blackfire dump.

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 28, 2017

capture d ecran de 2017-11-28 15-17-12

@jkfran

This comment has been minimized.

Show comment
Hide comment
@jkfran

jkfran Nov 28, 2017

Contributor

@Quetzacoalt91 So, it can be merged? 😄

Contributor

jkfran commented Nov 28, 2017

@Quetzacoalt91 So, it can be merged? 😄

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.4.0 milestone Nov 29, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Nov 29, 2017

Member

Indeed. thank you @jkfran

Member

Quetzacoalt91 commented Nov 29, 2017

Indeed. thank you @jkfran

@Quetzacoalt91 Quetzacoalt91 merged commit 7247352 into PrestaShop:develop Nov 29, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless changed the title from BO: Better performance in order template to Better performance in order template Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment