New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless die in StoresController #8548

Merged
merged 2 commits into from Nov 29, 2017

Conversation

Projects
None yet
4 participants
@sarjon
Member

sarjon commented Nov 25, 2017

Questions Answers
Branch? develop
Description? Just removes useless die from code.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? See code change.

This change is Reviewable

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Nov 25, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
           

Complexity decreasing per file
==============================
+ controllers/front/StoresController.php  -14
         

See the complete overview on Codacy

codacy-bot commented Nov 25, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
           

Complexity decreasing per file
==============================
+ controllers/front/StoresController.php  -14
         

See the complete overview on Codacy

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 25, 2017

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.4.0 milestone Nov 29, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 67e5f5e into PrestaShop:develop Nov 29, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 29, 2017

Thank you @sarjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment