New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store hours migration #8556

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@kpodemski
Contributor

kpodemski commented Nov 27, 2017

Questions Answers
Branch? develop
Description? hours are not properly migrated due to problem with " "
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.4.0 milestone Nov 28, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 8898ed0 into PrestaShop:develop Nov 28, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 28, 2017

Thank you @kpodemski

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Jan 9, 2018

Contributor

Hey @Quetzacoalt91 why it is not a part of 1.7.3.1 or something? Why we need to wait to much time for a fix related to data migration?

Contributor

kpodemski commented Jan 9, 2018

Hey @Quetzacoalt91 why it is not a part of 1.7.3.1 or something? Why we need to wait to much time for a fix related to data migration?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Jan 12, 2018

Member

At the moment we merged this PR, the develop branch was already for the version 1.7.4.x.

Making it available for 1.7.3.x requires to cherry-pick on the previous branch, as I just did on #8670

Member

Quetzacoalt91 commented Jan 12, 2018

At the moment we merged this PR, the develop branch was already for the version 1.7.4.x.

Making it available for 1.7.3.x requires to cherry-pick on the previous branch, as I just did on #8670

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Jan 12, 2018

Contributor

Great, thank you

Contributor

kpodemski commented Jan 12, 2018

Great, thank you

@DaleyKD

This comment has been minimized.

Show comment
Hide comment
@DaleyKD

DaleyKD Feb 1, 2018

Is it just me, and I'm not a PHP developer by day (C#), but during my upgrade, the error [ERROR] PHP 1.7.0.0 /* PHP:ps1700_stores(); */ is shown. Since I have ZERO items in the stores table, it's returning false. Wouldn't that be the cause? Shouldn't we want to return true by default?

DaleyKD commented Feb 1, 2018

Is it just me, and I'm not a PHP developer by day (C#), but during my upgrade, the error [ERROR] PHP 1.7.0.0 /* PHP:ps1700_stores(); */ is shown. Since I have ZERO items in the stores table, it's returning false. Wouldn't that be the cause? Shouldn't we want to return true by default?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 30, 2018

Member

You're right @DaleyKD. Another pull-request has been created for that point: #10218

Member

Quetzacoalt91 commented Aug 30, 2018

You're right @DaleyKD. Another pull-request has been created for that point: #10218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment