New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more informations from args in Hooks profiler #8557

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
2 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Nov 28, 2017

Questions Answers
Branch? develop
Description? Again, the idea is to give to module developers all the information they may need to customize their back office on modern pages. After the information about called/not called hooks, this is a pull request to allow them to visit every module/hook arguments.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? See the captures, you can compare between develop and this branch, when clicking on the "Hooks" section of the debug toolbar in dev mode.

Before

before

After

after

Important guidelines


This change is Reviewable

@mickaelandrieu mickaelandrieu added this to the 1.7.4.0 milestone Nov 28, 2017

@Quetzacoalt91

Nice! However I require a rebase in there. :)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Nov 28, 2017

Contributor

Done 👍

Contributor

mickaelandrieu commented Nov 28, 2017

Done 👍

@PrestaShop PrestaShop deleted a comment from codacy-bot Nov 28, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 2bc82de into PrestaShop:develop Nov 29, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 29, 2017

Thank you @mickaelandrieu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment