New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix the email validator" #8568

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Nov 30, 2017

Reverts #8531

See http://forge.prestashop.com/browse/PSCSX-9282 for details


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 30, 2017

Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The description shouldn't be empty.
  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Collaborator

prestonBot commented Nov 30, 2017

Hi!

Your pull request description seems to be incomplete or malformed:

  • The description shouldn't be empty.
  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Nov 30, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/Unit/classes/ValidateCoreTest.php  18
- classes/Validate.php  120
         

See the complete overview on Codacy

codacy-bot commented Nov 30, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/Unit/classes/ValidateCoreTest.php  18
- classes/Validate.php  120
         

See the complete overview on Codacy

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu
Contributor

mickaelandrieu commented Nov 30, 2017

Thank you @Quetzacoalt91

@mickaelandrieu mickaelandrieu merged commit 0b91372 into 1.6.1.x Nov 30, 2017

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the revert-8531-PSCSX-9282 branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment