New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify version for all PS native modules #8605

Merged
merged 1 commit into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@eternoendless
Member

eternoendless commented Dec 11, 2017

Questions Answers
Branch? 1.7.3.x
Description? Updated composer requirement for all native modules.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Nothing to test

This change is Reviewable

@eternoendless eternoendless added the 1.7.x label Dec 11, 2017

@eternoendless eternoendless added this to the 1.7.3.0 milestone Dec 11, 2017

@eternoendless eternoendless requested a review from Quetzacoalt91 Dec 11, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Dec 11, 2017

Member

I wonder if we don't need two levels in the version given in that file, or composer will consider all major versions as acceptable.

Member

Quetzacoalt91 commented Dec 11, 2017

I wonder if we don't need two levels in the version given in that file, or composer will consider all major versions as acceptable.

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Dec 12, 2017

Member

The way I see it, if we stick modules to SemVer, minor and patch releases shouldn't break compatibility and thus be compatible with PS 1.7.3.x all the way to 1.7.4

Member

eternoendless commented Dec 12, 2017

The way I see it, if we stick modules to SemVer, minor and patch releases shouldn't break compatibility and thus be compatible with PS 1.7.3.x all the way to 1.7.4

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Dec 13, 2017

Member

@eternoendless, we cannot merge the PR till this error occurs:

$ bash travis-scripts/install-prestashop
Warning: World-writable config file '/home/travis/.my.cnf' is ignored
* Installing PrestaShop, this may take a while ...
Errors :
Array
(
   [0] => Cannot install module "welcome"
)
Member

Quetzacoalt91 commented Dec 13, 2017

@eternoendless, we cannot merge the PR till this error occurs:

$ bash travis-scripts/install-prestashop
Warning: World-writable config file '/home/travis/.my.cnf' is ignored
* Installing PrestaShop, this may take a while ...
Errors :
Array
(
   [0] => Cannot install module "welcome"
)

@eternoendless eternoendless merged commit 0ebfcef into PrestaShop:1.7.3.x Dec 21, 2017

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:update-modules-version branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment