New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed newsletter registration date doc #8606

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
5 participants
@c100k
Contributor

c100k commented Dec 11, 2017

Questions Answers
Branch? develop
Description? The PHPDoc of the property had been copy pasted from the IP registration one
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Only documentation has been changed

Important guidelines


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Dec 11, 2017

Collaborator

Hello c100k!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Dec 11, 2017

Hello c100k!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Dec 11, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ classes/Customer.php  -127
         

See the complete overview on Codacy

codacy-bot commented Dec 11, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ classes/Customer.php  -127
         

See the complete overview on Codacy

@mickaelandrieu mickaelandrieu changed the title from CO: Fix newsletter registration date doc to Fixed newsletter registration date doc Dec 13, 2017

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Dec 13, 2017

Contributor

Thank you @c100k!

Contributor

mickaelandrieu commented Dec 13, 2017

Thank you @c100k!

@mickaelandrieu mickaelandrieu merged commit d02563f into PrestaShop:develop Dec 13, 2017

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.4.0 milestone Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment