New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bad display manufacturer when multishop #8611

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
6 participants
@okom3pom
Contributor

okom3pom commented Dec 12, 2017

Questions Answers
Branch? PrestaShop 1.7
Description? Manufacturer are display two or more time when multishop is enable
Type? bug fix
Category? BO
BC breaks? no
How to test? Active multiboutique go to specific price rule

Same as #8540 for 1.6


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Dec 12, 2017

Collaborator

Hello okom3pom!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Dec 12, 2017

Hello okom3pom!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Dec 12, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ controllers/admin/AdminSpecificPriceRuleController.php  -16
         

See the complete overview on Codacy

codacy-bot commented Dec 12, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ controllers/admin/AdminSpecificPriceRuleController.php  -16
         

See the complete overview on Codacy

@mickaelandrieu mickaelandrieu changed the title from CO: Fix bad display manufacturer when multishop to Fixed bad display manufacturer when multishop Dec 13, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Dec 19, 2017

Thank you @okom3pom

@Quetzacoalt91 Quetzacoalt91 merged commit f29c520 into PrestaShop:develop Dec 19, 2017

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@okom3pom okom3pom deleted the okom3pom:okom3pom-fix-manufa branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment