New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do no rely on external URL for tests (Returns different content) (1.7.3.x) #8630

Merged
merged 1 commit into from Dec 21, 2017

Conversation

Projects
None yet
3 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Dec 21, 2017

Questions Answers
Branch? 1.7.3.x
Description? Github avatar returns now different content at each call, which breaks the test. We now rely on a local asset
Type? bug fix
Category? TE
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Travis must pass

This change is Reviewable

@tomlev

tomlev approved these changes Dec 21, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Dec 21, 2017

Thank you @Quetzacoalt91

@eternoendless eternoendless merged commit ba2cabc into PrestaShop:1.7.3.x Dec 21, 2017

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:fix-module-conf-gravatar-1.7.3.x branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment