New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PHP 7.x #8644

Merged
merged 1 commit into from Dec 29, 2017

Conversation

Projects
None yet
2 participants
@RubenMartins
Contributor

RubenMartins commented Dec 28, 2017

Questions Answers
Branch? 1.6.1.x
Description? On opening the modules page(/index.php?controller=AdminModules) with debug On appears two error for each module on error_log file creating a big file size.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? On opening the modules page(/index.php?controller=AdminModules) with debug On

This change is Reviewable

Update AdminModulesController.php
Prevent error_log
1- [2] Illegal string offset 'MODULE_NAME'
2- [8] Array to string conversion

On opening the modules page(/index.php?controller=AdminModules) with debug On
@Quetzacoalt91

Fix for PHP 7. Good catch @RubenMartins

@Quetzacoalt91 Quetzacoalt91 added this to the 1.6.1.18 milestone Dec 29, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 7daa3a1 into PrestaShop:1.6.1.x Dec 29, 2017

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RubenMartins RubenMartins changed the title from Update AdminModulesController.php to Fix for PHP 7.x Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment