New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify string for product page #8645

Merged
merged 1 commit into from Jan 2, 2018

Conversation

Projects
None yet
4 participants
@LouiseBonnard
Contributor

LouiseBonnard commented Dec 29, 2017

Questions Answers
Branch? develop
Description? Modify source string for product page
Type? improvement
Category? BO
BC breaks? No
Deprecations? No
Fixed ticket? BOOM-3948
How to test? Open a product page

Important guidelines


This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Dec 29, 2017

Collaborator

Hello LouiseBonnard!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Dec 29, 2017

Hello LouiseBonnard!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Jan 2, 2018

Member

This is unfortunately too late for the versions 1.7.3.x, as we already froze the string for this minor version.

This PR has to wait for 1.7.4.0.

Member

Quetzacoalt91 commented Jan 2, 2018

This is unfortunately too late for the versions 1.7.3.x, as we already froze the string for this minor version.

This PR has to wait for 1.7.4.0.

@Quetzacoalt91 Quetzacoalt91 changed the base branch from 1.7.3.x to develop Jan 2, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 7298220 into PrestaShop:develop Jan 2, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LouiseBonnard

This comment has been minimized.

Show comment
Hide comment
@LouiseBonnard

LouiseBonnard Jan 3, 2018

Contributor

Okay, thanks @Quetzacoalt91. So when strings are frozen for the version I'm looking for, I need to pull the PR on the develop branch ?

Contributor

LouiseBonnard commented Jan 3, 2018

Okay, thanks @Quetzacoalt91. So when strings are frozen for the version I'm looking for, I need to pull the PR on the develop branch ?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Jan 3, 2018

Member

Exactly :)

Member

Quetzacoalt91 commented Jan 3, 2018

Exactly :)

@eternoendless eternoendless added this to the 1.7.4.0 milestone Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment