Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CLDR to Core #8662

Merged
merged 2 commits into from Jan 10, 2018

Conversation

@LittleBigDev
Copy link
Contributor

commented Jan 10, 2018

Questions Answers
Branch? develop
Description? CLDR library must be independent from Symfony and business code
Type? new feature
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? composer dump-autoload && composer phpunit-legacy

This change is Reviewable

@LittleBigDev LittleBigDev added the 1.7.x label Jan 10, 2018

@LittleBigDev LittleBigDev requested a review from eternoendless Jan 10, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

:lgtm:


Reviewed 24 of 24 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@LittleBigDev LittleBigDev merged commit c8cfe83 into PrestaShop:develop Jan 10, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
code-review/reviewable 24 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

Thank you a lot! <3

@eternoendless eternoendless added this to the 1.7.4.0 milestone Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.