New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Product catalogAction #8710

Merged
merged 25 commits into from Aug 20, 2018
Commits
Jump to file or symbol
Failed to load files and symbols.
+2 −2
Diff settings

Always

Just for now

Viewing a subset of changes. View all

Improved deprecation error message

  • Loading branch information...
mickaelandrieu committed Aug 6, 2018
commit 80cd5d04436d205be60d16d7568596caca39f1f3
@@ -970,14 +970,14 @@ public function catalogFiltersAction($quantity = 'none', $active = 'none')
}
/**
* @deprecated since 1.7.4.0, to be removed in 1.8 rely on CommonController::renderFieldAction
* @deprecated since 1.7.5.0, to be removed in 1.8 rely on CommonController::renderFieldAction
* @throws \OutOfBoundsException
* @throws \LogicException
* @throws \PrestaShopException
*/
public function renderFieldAction($productId, $step, $fieldName)
{
@trigger_error('This function is deprecated, use CommonController:renderFieldAction instead.', E_USER_DEPRECATED);
@trigger_error('This function is deprecated, use CommonController::renderFieldAction instead.', E_USER_DEPRECATED);
$productAdapter = $this->get('prestashop.adapter.data_provider.product');
$product = $productAdapter->getProduct($productId);
ProTip! Use n and p to navigate between commits in a pull request.