Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loaded details from database on module action #8714

Merged

Conversation

@Quetzacoalt91
Copy link
Member

commented Jan 29, 2018

Questions Answers
Branch? 1.7.3.x
Description? Update module details during request to avoid wrong action buttons to be displayed.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4721
How to test? Installing / upgrading a module should not display "upgrade" anymore as the next step.

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 changed the title Update loaded details from database Update loaded details from database on module action Jan 29, 2018

@eternoendless
Copy link
Member

left a comment

LGTM

@eternoendless eternoendless added this to the 1.7.3.1 milestone Feb 12, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Feb 12, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

commented Mar 7, 2018

Thank you @Quetzacoalt91

@eternoendless eternoendless merged commit c35af21 into PrestaShop:1.7.3.x Mar 7, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.